<div class="gmail_extra">I have no problem with also adding {op:string, left:string, right:string} to make everything clearer.</div><div class="gmail_extra"><br></div><div class="gmail_extra">I will throw exceptions if the objects are not of the correct type.<br>
<br><div class="gmail_quote">On Sat, Apr 28, 2012 at 3:41 AM, Liam <span dir="ltr"><<a href="mailto:xapian@networkimprov.net" target="_blank">xapian@networkimprov.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_extra"><br><div class="gmail_quote"><div class="im">On Fri, Apr 27, 2012 at 3:24 PM, Marius Tibeica <span dir="ltr"><<a href="mailto:mtibeica@gmail.com" target="_blank">mtibeica@gmail.com</a>></span> wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_extra"><br><div class="gmail_quote"><div class="im"><div>On Sat, Apr 28, 2012 at 12:37 AM, Liam <span dir="ltr"><<a href="mailto:xapian@networkimprov.net" target="_blank">xapian@networkimprov.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>Re the Query structure spec, looks good.<br><br></div></blockquote></div></div><div class="im">
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="gmail_extra"> Query (Query::op op_, const std::string &left, const std::string &right) {<br>
</div></blockquote><div><pre style="font-family:arial,helvetica,sans-serif">I think it can be handled by<br><div>{<br> op: string,<br> queries: [ object_querystructure1, ...]<br>}<br></div>with an array of two elements (the first being left and the second right)<br>
</pre></div></div></div></div></blockquote><div><br>True, but the user might mistakenly put >2 strings in the array, or mix objects and strings? so maybe<br><br>{op:string, left:string, right:string}<br><br>And that gives us the whole query-constructor API in one method, very nice.<br>
</div></div></div>
<br>_______________________________________________<br>
Xapian-devel mailing list<br>
<a href="mailto:Xapian-devel@lists.xapian.org">Xapian-devel@lists.xapian.org</a><br>
<a href="http://lists.xapian.org/mailman/listinfo/xapian-devel" target="_blank">http://lists.xapian.org/mailman/listinfo/xapian-devel</a><br>
<br></blockquote></div><br></div>