<div class="gmail_quote">On Wed, May 23, 2012 at 1:35 PM, Liam <span dir="ltr"><<a href="mailto:xapian@networkimprov.net" target="_blank">xapian@networkimprov.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><br><div class="gmail_quote">On Tue, May 22, 2012 at 8:12 PM, Liam <span dir="ltr"><<a href="mailto:xapian@networkimprov.net" target="_blank">xapian@networkimprov.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_quote"><div><br>Re latest code...<br></div></div></blockquote><div><br>Few more notes...<br></div></div></blockquote><div><br>And a few more!<br><br>Use "that" instead of "pThis" as the name for the unwrapped args.This()<br>
<br>There are currently tests for mBusy in both _do_async and AsyncOp::AsyncOp. We can remove the latter, and also make AsyncOp::AsyncOp take the unwrapped object, rather than do the unwrap itself.<br><br>Use "Type aVar = value;" where possible, since we're removing try blocks that required separate "Type aVar;".<br>
<br>The data argument for the _do functions should be named "data" vs "aData".<br><br>Could the DECLARE_POOL methods be defined once per class if the _process & _convert functions are passed as args to the _do functions and then stored in the AsyncOp object?<br>
<br></div></div>