<br><br><div class="gmail_quote">On Wed, May 23, 2012 at 1:35 PM, Liam <span dir="ltr"><<a href="mailto:xapian@networkimprov.net" target="_blank">xapian@networkimprov.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><br><div class="gmail_quote">On Tue, May 22, 2012 at 8:12 PM, Liam <span dir="ltr"><<a href="mailto:xapian@networkimprov.net" target="_blank">xapian@networkimprov.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_quote"><div><br>Re latest code...<br></div></div></blockquote><div><br>Few more notes... <br></div><div><br>In op.h, tryCallCatch, GetInstance, sendToThreadPool, kBusyMsg should be declared without static (since now used by multiple .cc files) and be defined in util.cc or similar.<br>
</div></div></blockquote><div><br>Actually, we can leave these function definitions in the header file; just de-static them.<br><br>If we use a single DECLARE_POOL(Class) per class, the _convert function will have to<br> delete (GetMset_data*) data<br>
since _done won't know the type to cast to.<br><br></div></div>