<br><br><div class="gmail_quote">On Wed, May 30, 2012 at 11:54 PM, Liam <span dir="ltr"><<a href="mailto:xapian@networkimprov.net" target="_blank">xapian@networkimprov.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><br><div class="gmail_quote">On Wed, May 30, 2012 at 12:17 PM, Marius Tibeica <span dir="ltr"><<a href="mailto:mtibeica@gmail.com" target="_blank">mtibeica@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
done<br></blockquote><div><br>Sorry I keep finding nits!<br></div></div></blockquote><div><br>invoke() should do 'that->mBusy = true', and move that line to before the 'new AsyncOp(...)'<br><br>DECLARE_UTILS<span dir="ltr" id=":2tm"> can now be global templates, I think:<br>
</span><div id=":2tl" dir="ltr" class="kl"> template<class T><br> handle<value> invoke(...) {<br> // replace classn with T</div><div id=":2tk" dir="ltr" class="kl"> use invoke<Enquire>(...);</div></div>
<div><br>We didn't consider allowing sync use of the AssembleDocument function (creates a document from a JS object spec). I'm fine leaving that async; it really shouldn't be called synchronously. But something to ponder...<br>
<br><br></div></div>