<div dir="ltr"><div><div>Hello .Is any additional normalization/code needed before the code for TfIdf can be merged ? Please do let me know.I want to get the code merged as soon as we can.<br><br></div>-Regards<br></div>-Aarsh<br>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Apr 3, 2013 at 1:04 AM, aarsh shah <span dir="ltr"><<a href="mailto:aarshkshah1992@gmail.com" target="_blank">aarshkshah1992@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>No Olly,there is no specific reason for that .I just decided to go with uppercase strings as that makes them easily visible and conspicuous when reading the documentation and also while reading the code.However, the case wont make any difference to the code.<br>
<br></div>-Regards<span class="HOEnZb"><font color="#888888"><br></font></span></div><span class="HOEnZb"><font color="#888888">-Aarsh</font></span><div><div class="h5"><br><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, Apr 2, 2013 at 8:39 AM, Olly Betts <span dir="ltr"><<a href="mailto:olly@survex.com" target="_blank">olly@survex.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Tue, Mar 26, 2013 at 09:29:53PM +0530, aarsh shah wrote:<br>
> Hello Guys. I have updated the code,tests,documentation,makefile entries<br>
</div>> and the registry entry of the* *TfIdf patch as per the feedback.Please do<br>
<div>> let me know if any additional changes are required before the patch can be<br>
> merged,<br>
<br>
</div>One question - the 3 character codes that TfIdfWeight takes are (I<br>
assume) modelled on those used by SMART:<br>
<br>
<a href="http://people.csail.mit.edu/jrennie/ecoc-svm/smart.html" target="_blank">http://people.csail.mit.edu/jrennie/ecoc-svm/smart.html</a><br>
<br>
But TfIdfWeight requires them to be in upper-case, while SMART documents<br>
them as being lowercase. Is there a reason for that?<br>
<br>
Cheers,<br>
Olly<br>
</blockquote></div><br></div></div></div></div></div></div>
</blockquote></div><br></div>