<div dir="ltr"><div><div><div>Hello,<br>I came across the file <b>omega.cc</b> which is in directory<b> xapain-application/omega/</b><br><br>In this file , atoi is used in <b>Percentage Relevance cutoff </b>(293 line no) as Percentage lies between 0-100 their is no need to modify atoi . But do we need to check for error's ? <br></div><br>Second Implementation is in <b>collapsing</b> (301) in which we collapse set of document under a key,range of this key has not been defined anywhere so we can increase the size of the key over here to accumulate more key's ? <br><br></div>Third Implementation is in <b>Sort</b> (330) And I am not sure what is the val value over here is ?? Is it the entire string of sorted value number's as cgi_params is multimap and find returns the iterator at which it find the element containing the key value ? And I am not sure whether to modify atoi over here. <br><br>val = cgi_params.find("SORT");<br> if (val != cgi_params.end()) {<br> sort_key = atoi(val->second.c_str());<br><br></div><div>Thank You,<br></div><div>Priyank Bhatt<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 17 December 2014 at 03:38, Olly Betts <span dir="ltr"><<a href="mailto:olly@survex.com" target="_blank">olly@survex.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Dec 17, 2014 at 01:15:12AM +0530, Priyank Bhatt wrote:<br>
> I came across this function *HtmlParser::decode_entities(string &s)* in<br>
> *xapian-application/omega/htmlparse.cc* which basically does is extract hex<br>
<span class="">> value if any or extract number.<br>
<br>
</span>The code you refer to is actually parsing a decimal value (like &) -<br>
the hex case (like &) uses sscanf().<br>
<span class=""><br>
> For extracting number atoi is used and value<br>
> returned by it is stored in variable "val" , I think so replacing atoi with<br>
> strtoul would be useful here as number can have larger value although the<br>
> variable "val" is unsigned int so i need to change the that definition of<br>
> "val" also. Is that ok to do so ? Just need to clarify .<br>
<br>
</span>We ultimately pass val to Xapian::Unicode::nonascii_to_utf8() which<br>
takes "unsigned" so there's not much point making val a wider type<br>
here.<br>
<br>
While ISO C/C++ only guarantee that int is at least 16 bits, in<br>
practice it is 32 bits on the platforms we support.<br>
<br>
Cheers,<br>
Olly<br>
</blockquote></div></div>