[Xapian-tickets] [Xapian] #206: Serialization for Xapian::Query doesn't work for PostingSource queries.
Xapian
nobody at xapian.org
Wed Feb 18 05:06:51 GMT 2009
#206: Serialization for Xapian::Query doesn't work for PostingSource queries.
----------------------------+-----------------------------------------------
Reporter: armin.ronacher | Owner: richard
Type: enhancement | Status: assigned
Priority: normal | Milestone: 1.1.1
Component: Library API | Version: SVN trunk
Severity: minor | Resolution:
Keywords: | Blockedby: 295
Platform: All | Blocking:
----------------------------+-----------------------------------------------
Comment(by richard):
Now that I have a nearly complete patch, I'm not so worried about the API
needing to change incompatibly: the changes the current patch makes to the
files in include/xapian/ are:
- Changing the prototype of a method in Query::Internal (but that's not
part of the API, so should be fine, I think). Might break ABI, though;
I'd need to do a deeper analysis to determine that.
- Adding static Query unserialise(const std::string & s, const
SerialisationContext & ctx); to the Query class. This shouldn't be any
kind of problem.
- Adding "friend class SerialisationContext" to Xapian::Weight. This
shouldn't be any kind of problem.
- Adding xapian/serialisationcontext.h - also shouldn't be any problem.
If I get a completed patch, I'd still like to consider applying it before
1.1.0, (unless we're really getting close to having 1.1.0 ready; currently
I think we're still around a month of work from it) - my experience is
that patches sitting in the tracker tend to decay quite quickly, and need
a fair bit of work to apply. There is quite a bit of code here, but it
doesn't have many deep interactions with other parts of xapian, so I feel
that there's a fairly low risk of destabilisation due to it.
--
Ticket URL: <http://trac.xapian.org/ticket/206#comment:15>
Xapian <http://xapian.org/>
Xapian
More information about the Xapian-tickets
mailing list