[Xapian-devel] Re: [Xapian-commits] 7283: trunk/xapian-core/ trunk/xapian-core/net/

[Olly Betts]

On Wed, Oct 04, 2006 at 01:27:20PM +0100, richard wrote:
> SVN root:       svn://svn.xapian.org/xapian
> Changes by:     richard
> Revision:       7283
> Date:           2006-10-04 13:27:17 +0100 (Wed, 04 Oct 2006)
> 
> Log message (2 lines):
> Use "unsigned char" instead of "char" when serialising lengths, to avoid
> problems on platforms where char is signed (eg, windows).

Not just windows - char is also signed on x86 and x86_64 linux where I
wrote and tested this code...

I considered this issue while writing the code, and I don't think
there's actually a problem here.  What do you think will go wrong if
char is signed?

Cheers,
    Olly