[Xapian-devel] Re: [Xapian-commits] 7283: trunk/xapian-core/ trunk/xapian-core/net/

[Olly Betts]

On Wed, Oct 04, 2006 at 10:39:55PM +0100, richard at lemurconsulting.com wrote:
> On Wed, Oct 04, 2006 at 08:56:32PM +0100, Olly Betts wrote:
> > > http://www.tartarus.org/~richard/xapian-patches/queryparser-incremental.patch
> > 
> > I notice a bug - you need to restart the allterms iteration if there's
> > no "I" term...
> 
> I'm not convinced it is actually a bug - the skip_to() will move to the
> first term after the non-existent "I" term, but all the non-prefixed terms
> will sort after the "I" term, so the second skip_to() will still move to
> the right place.  (Assuming "name" begins with a lowercase letter, which I
> think it always will at present.)

What if the last term is prefixed (by a letter less than I) though?

> (All these measurements are using quartz
> - the better compression in flint might make the differences smaller, I
> suppose, since these terms will match many documents.)

It won't be hugely better - flint's biggest compression gain is in
positional information, which I guess you aren't storing for these
terms.

> Perhaps, after the 0.9.7 release, we should move any bug fixes to 0.9.7 to
> a separate branch, and then apply any patches like these, and the UTF-8
> stuff, to the SVN trunk.

I was a bit nervous about creating a branch for 0.9.7 and putting the
UTF-8 stuff on the trunk, as I imagined I'd have to fix up the release
scripts.  But they built a snapshot of the UTF-8 branch without any
changes, so I think we should be able to do this.  The tinderbox stuff
might need attention, and we might hit disk space issues on some machines
trying to build two branches.

I think perhaps we should wait a short while to see if any immediate
problems pop up, then tag the branch point and merge the UTF-8 branch
in.

Cheers,
    Olly