[Xapian-devel] Error handling in the bindings

[Olly Betts]

On Fri, Mar 09, 2007 at 01:05:48PM +0000, Richard Boulton wrote:
> Checked - the only difference was whitespace, and the license statement 
> for tcl8's exception handling, which wasn't being put into the 
> tcl8/xapian_wrap.cc file.

That's great, thanks for checking.

> I've changed the latter to put the license 
> statement back, since this happens with other such statements and I 
> thought I should be consistent, but I'm not sure if it's really a good 
> idea to have the license statements copied into the middle of the 
> generated file.

I think it's good to include them, though the top would be a much better
place than the middle!

And tangentially related...

The snapshot script is currently failing ($self is making it through to
C++ code), but it looks like that's because I installed the latest SWIG
SVN to the wrong prefix so it's still using 1.3.30rc1.  Which means
0.9.10 was generated with the wrong SWIG version, so the PHP5 Query
overload issue isn't fixed.  I think that might also mean that you need
the patch for Python 2.5 still too though Michael Sanders seemed to
build it OK on Windows.  Perhaps it's different on Unix.

Anyway, I've reinstalled the latest SWIG in the right prefix now so
that should fix snapshots.  I'll stick the patches in the release notes
but I'm away for the next week, so I don't have time to verify that
they're still required.

Cheers,
    Olly