[Xapian-devel] Test of Search::Xapian::Writable Database, and how to send a patch

[Kosei MORIYAMA]

Thank you for your reply.

I see that I prefer to make ticket in trac. I also understood to
contain information why the patch is needed.

Now I wrote that test simply because there are no test of that
methods. As you pointed out, it seems that there are less nessecity
about this patch. I'll think it over once more.

Cheers,
Kosei

On Tue, Apr 14, 2009 at 5:27 AM, Richard Boulton
<richard at lemurconsulting.com> wrote:
> On Tue, Apr 14, 2009 at 05:21:36AM +0900, Kosei MORIYAMA wrote:
>> I'm Kosei MORIYAMA. I'm a student application gsoc 2009, Xapian and
>> SWIG project.
>>
>> I wrote a test, search-xapian/t/writable database.t , which tests
>> methods of Search::Xapian::Writable Database, replace_document,
>> replace_document_by_term, delete_document and delete_document_by_term.
>>
>> Then I thought to send a patch of this test to be reviewed. Following
>> xapian-core/HACKING file's 'Submitting Patches' section, run following
>> command,
>>
>> $ svn diff > writable database.diff
>>
>> and attach this file to this mail.
>
> Thanks for the patch.
>
>> Is this correct way of sending patch? And Do I need to send any other
>> information about this patch?
>
> The best thing to do with patches is to make a ticket for them in our trac
> instance (at http://trac.xapian.org/).  This way, they don't get lost and
> forgotten.  Also, large patches may not be accepted by the mailing list
> software (it has a size limit, though I can't remember how large that limit
> is off-hand).
>
> Generally, with a patch you should include an explanation of why the patch
> is a good idea.  In this case, I don't think there's anything obvious extra
> that needs to be included.
>
> --
> Richard
>