[Xapian-discuss] timing behaviour for creating large queries

[Olly Betts]

On Wed, Feb 07, 2007 at 05:27:35PM +0000, Richard Boulton wrote:
> A very interesting performance issue, this.

I think we shouldn't be validating so often in a non-debug build.  If I
follow this correctly, we're really just checking that any query tree
simplifications we have just made were valid.  If this check fails it
means there's a bug in the library code, so these are really internal
consistency checks of the type we typically specify using the Assert
family of macros.

So I think we should conditionalise the recursive check on the
appropriate macro and perhaps add a call to validate the whole query
once just before we start to convert it to a posting list tree when
running the match.

Cheers,
    Olly