[Xapian-discuss] FIXMEs in Search::Xapian

[Olly Betts]

On Wed, Sep 01, 2010 at 06:21:28PM +0100, Tim Brody wrote:
> Carrying on this conversation:
> http://lists.tartarus.org/pipermail/xapian-discuss/2007-March/003513.html
> 
> void
> TermGenerator::set_stopper(stopper)
>     Stopper * stopper
>     CODE:
>     // FIXME: no corresponding SvREFCNT_dec(), but a leak seems better
> than
>     // a SEGV!
>     SvREFCNT_inc(ST(1));
>     THIS->set_stopper(stopper);
> 
> It would be good to fix these FIXMEs.
> 
> A class-level HASH could be maintained of contained objects.
> 
> Any other solutions?

This is what we do for Python.

Perhaps now is a good time to switch to the SWIG-generated Python bindings
though, rather than working on code we're intending to replace.

These were done for GSoC last year by Kosei Moriyama on a branch.  He
expressed interest in doing the merging and integration work himself,
but I think he's been busy with his academic work since.  I've Cc:-ed
him on this mail in case he wants to get involved.

I've just performed a merge from current trunk to the branch, which was
pretty painless, and the tests all still pass, so I've committed that.

I think the best next step is just to merge the branch to trunk, where
it can be an optional new language in xapian-bindings, and sort out the
remaining issues there.  But currently it is branches/gsoc2009-kosei in
SVN.

Cheers,
    Olly