[Xapian-discuss] Mime2Text library, derived from omindex

Liam xapian at networkimprov.net
Mon Feb 13 08:33:05 GMT 2012


On Sun, Jan 15, 2012 at 8:34 PM, Olly Betts <olly at survex.com> wrote:

>
> > The existing code expects a filename, so I feel we should stick with that
> > for the first version of this, although I agree it should take a stream
> > type eventually.
>
> For code only used in omindex, that's fine - we control the caller(s)
> and can just change how things work if needed.
>
> But if we're going to split this off into a library, we're committing to
> support the API we provide for a significant length of time, and to
> providing sane upgrade paths for any changes which later get made.
>

OK, true, but we shouldn't define the stream-oriented API until we know
exactly what a future omindex needs in that area. So I'd suggest starting
with an omindex-internal library with pathname API. When we switch to
streams, we can move the library to its own package.

>
> > Why is "command" in Mime2Text::Fields?  It doesn't seem to be a field.
> >
> > It's for informational purposes, what external command produced these
> > results, if any.
>
> It isn't a field though.
>

Shall I make it a second output argument?

>
Liam


More information about the Xapian-discuss mailing list