[Xapian-discuss] empty FD after reopen since version 1.2.16

[matthias lay]

Hi Olly,


On 04/28/2015 07:40 AM, Olly Betts wrote:
> On Mon, Apr 27, 2015 at 02:23:25PM +0200, matthias lay wrote:
>> after upgrading xapian I encountered the same problem as
>> described in ticket #645 Read block errors after reopen()
>> 
>> in our setup its 100% reproducible after each reopen(). I
>> downgraded again and it seems the problem occurs in Version
>> 1.2.16 and above. in <=1.2.15 everything works fine without
>> seeing this error once.
> 
> I suspect this commit fixes your issue - you can probably just
> apply the chert parts to 1.2.x easily, though I've not tried to
> backport it yet:
> 
> http://trac.xapian.org/changeset/1900eca6d325e9185b9f9f5c75a4a4a545616d7f/git
>
>  Thanks for narrowing down the release which introduced this - the
> relevant change in 1.2.16 is presumably this one:
> 
> | * Reuse a cursor for reading values from valuestreams rather than
> creating |   a new one each time.  This can dramatically reduce the
> number of blocks |   redundantly reread when sorting by value.  The
> rereads will generally get |   served from VM cache, but there's
> still an overhead to that.
> 
> Before that we just created a cursor each time, so the underlying 
> cursor bug wouldn't be triggered in this case.
> 
> Cheers, Olly
> 


just tested your patch with 1.2.20 and the exception hasnt occured so
far. so seems to fix the problem.

thx for the fast fix

Greetz
	Matze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.xapian.org/pipermail/xapian-discuss/attachments/20150428/fd9041bb/attachment.sig>