[Xapian-discuss] Perl bindings and MatchSpy

[Andreas Marienborg]

On 19 August 2015 at 20:55:32, Olly Betts (olly at survex.com) wrote:
On Wed, Aug 19, 2015 at 05:31:31PM +0700, Andreas Marienborg wrote:  

> If I want to create a patch, should it be against the xapian-bindings  
> directory/repo? or somewhere else?  

Against the search-xapian directory of the git repo would be best.  


Hey, I made a branch from svn/1.2 on github, and tried to forward port 
the changes to this branch. I managed to wrap the ValueCountMatchSpy,
and write tests to ensure it is working.

In the original code there was also some code for PerlMatchSpy, but I
did not manage to get this working yet. My XS/C-skills are rather limited
unfortunately.

If someone with more XS-exerpience could take a look and provide
some feedback, that would be great.

I created a pull request[1]. I would like to get the PerlMatchSpy thing
working as well, but it might be better to get the wrapping of the 
ValueCountMatchSpy merged/released regardless of the PerlMatchSpy
thing?

Any and all feedback is much appreciated :)

- a

[1]: https://github.com/xapian/xapian/pull/73