[Xapian-tickets] [Xapian] #196: makedepend tool can't cope with long INCLUDE paths
Xapian
nobody at xapian.org
Thu Apr 24 02:15:35 BST 2008
#196: makedepend tool can't cope with long INCLUDE paths
-------------------------------+--------------------------------------------
Reporter: charlie | Owner: charlie
Type: defect | Status: new
Priority: normal | Milestone: 1.1.0
Component: MSVC makefiles | Version: SVN HEAD
Severity: normal | Resolution:
Keywords: | Blockedby:
Platform: Microsoft Windows | Blocking:
-------------------------------+--------------------------------------------
Changes (by olly):
* owner: newbugs => charlie
* status: assigned => new
* component: Build system => MSVC makefiles
* milestone: => 1.1.0
Old description:
> The port of makedepend we're using can't cope with include paths longer
> than 512
> bytes - according to Paul Rudin:
> "A number of those command line args are copied
> around with strcpy where the buffers involved are BUFSIZ large. BUFSIZ
> seems to be only 512 (from stdio.h) on my system so it's pretty easy
> to get buffer overflows. That -I"..." string that caused the problem
> was more than 512 chars for example. "
>
> This can cause buffer overrun errors in makedepend, if the Windows system
> has a
> particularly large INCLUDE path in its environment variables.
New description:
The port of makedepend we're using can't cope with include paths longer
than 512
bytes - according to Paul Rudin:
"A number of those command line args are copied
around with strcpy where the buffers involved are BUFSIZ large. BUFSIZ
seems to be only 512 (from stdio.h) on my system so it's pretty easy
to get buffer overflows. That -I"..." string that caused the problem
was more than 512 chars for example. "
This can cause buffer overrun errors in makedepend, if the Windows system
has a
particularly large INCLUDE path in its environment variables.
--
Comment:
If you're going to stick with the makedepend implementation, can you
please at least patch it to die if the buffer would overflow?
--
Ticket URL: <http://trac.xapian.org/ticket/196#comment:6>
Xapian <http://trac.xapian.org>
Xapian
More information about the Xapian-tickets
mailing list