[Xapian-tickets] [Xapian] #196: makedepend tool can't cope with long INCLUDE paths

[Xapian]

#196: makedepend tool can't cope with long INCLUDE paths
-------------------------------+--------------------------------------------
 Reporter:  charlie            |        Owner:  charlie 
     Type:  defect             |       Status:  closed  
 Priority:  normal             |    Milestone:  1.1.0   
Component:  MSVC makefiles     |      Version:  SVN HEAD
 Severity:  normal             |   Resolution:  fixed   
 Keywords:                     |    Blockedby:          
 Platform:  Microsoft Windows  |     Blocking:          
-------------------------------+--------------------------------------------

Comment(by olly):

 Thanks for the patch.

 I'd say "fixed" isn't exactly right (unless MSVC imposes a limit on the
 size of the INCLUDE path) since users could still hit this, but it's
 probably the closest option given the resolutions we have to choose from.

 The "#if defined" problem was fixed by a patch from Charlie a while ago:

 http://trac.xapian.org/changeset?new=9712@trunk%2Fxapian-maintainer-
 tools%2Fwin32msvc%2Fmakedepend%2Fifparser.c&old=8996 at trunk%2Fxapian-
 maintainer-tools%2Fwin32msvc%2Fmakedepend%2Fifparser.c

 Hmm, actually looking at the source around there, there's a case to handle
 "defined" in parse_value(), which should handle "!defined", since the '!'
 case recursively calls parse_value().

 So that change doesn't seem to do anything.  I suspect the warnings
 reported (by Paul?) were actually due to #239 and the above change got
 accidentally included with some other updates.

-- 
Ticket URL: <http://trac.xapian.org/ticket/196#comment:9>
Xapian <http://trac.xapian.org>
Xapian