[Xapian-tickets] [Xapian] #280: Review storage of parameters in Query

Xapian nobody at xapian.org
Sat Jun 28 12:40:07 BST 2008


#280: Review storage of parameters in Query
-------------------------+--------------------------------------------------
 Reporter:  richard      |        Owner:  olly    
     Type:  enhancement  |       Status:  assigned
 Priority:  normal       |    Milestone:  1.1.0   
Component:  Library API  |      Version:  SVN HEAD
 Severity:  normal       |   Resolution:          
 Keywords:               |    Blockedby:          
 Platform:  All          |     Blocking:          
-------------------------+--------------------------------------------------

Comment(by richard):

 I had just about come to the same conclusions as you, that subclassing is
 probably the way to go.

 One approach to getting the internal class out of the header is to make an
 "InternalPtr" class which wraps the reference counted pointer, and using a
 pointer to that instead.  This leads to an extra redirection, which is
 annoying, but I think the benefit of not having the implementation in the
 public header would be worth it (and it's not in a particularly
 performance critical place).

 I have an experimental patch which does this which I'll attach shortly.

-- 
Ticket URL: <http://trac.xapian.org/ticket/280#comment:2>
Xapian <http://xapian.org/>
Xapian



More information about the Xapian-tickets mailing list