[Xapian-tickets] [Xapian] #303: UUID functions missing on Windows

Xapian nobody at xapian.org
Sun Nov 9 13:22:47 GMT 2008


#303: UUID functions missing on Windows
-------------------------------+--------------------------------------------
 Reporter:  charliejuggler     |        Owner:  richard 
     Type:  defect             |       Status:  reopened
 Priority:  normal             |    Milestone:  1.1.0   
Component:  Backend-Flint      |      Version:  SVN HEAD
 Severity:  normal             |   Resolution:          
 Keywords:                     |    Blockedby:          
 Platform:  Microsoft Windows  |     Blocking:          
-------------------------------+--------------------------------------------
Changes (by olly):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 A few cleanups:

  * Use named constants instead of "magic numbers".
  * Fix a few minor non-standard formatting issues.
  * {{{throw std::bad_alloc()}}} if {{{UuidToString()}}} fails.
  * {{{#include <cstring>}}} since we use functions from it ({{{memset}}},
 etc.)
  * Mark the exceptional cases as {{{rare()}}}.
  * Don't cast away {{{const}}}.
  * Make copying the result of {{{UuidToString()}}} robust so it can never
 overflow the supplied 37 byte buffer even if {{{UuidToString()}}}
 misbehaves.

 Can you test the shortly-to-be-attached patch?

-- 
Ticket URL: <http://trac.xapian.org/ticket/303#comment:17>
Xapian <http://xapian.org/>
Xapian



More information about the Xapian-tickets mailing list