[Xapian-tickets] [Xapian] #303: UUID functions missing on Windows

[Xapian]

#303: UUID functions missing on Windows
-------------------------------+--------------------------------------------
 Reporter:  charliejuggler     |        Owner:  richard 
     Type:  defect             |       Status:  assigned
 Priority:  normal             |    Milestone:  1.0.9   
Component:  Backend-Flint      |      Version:  SVN HEAD
 Severity:  normal             |   Resolution:          
 Keywords:                     |    Blockedby:          
 Platform:  Microsoft Windows  |     Blocking:          
-------------------------------+--------------------------------------------

Comment(by olly):

 Some other comments:

  * I think msvc_uuid.{h,cc} is the wrong name choice - it's not specific
 to the compiler MSVC, but to the platform.  I suggest win32_uuid.{h,cc}
 since "win32" is arguably the relevant aspect of the platform (and this is
 a wrapper around the win32 UUID API functions).

  * I think msvc_uuid.h should error out if {{{__WIN32__}}} isn't defined -
 there's no reason to include it on other platforms, so it's better to
 catch if we do (c.f. safewindows.h and safewinsock2.h).

  * One of the files lacks a '\n' at the end, which some compilers don't
 handle (I'll add a note about that to HACKING).

  * The code formatting doesn't follow the rest of Xapian in several
 regards (especially noticeable is the indentation of "}" and spacing
 around "(" and ")").

-- 
Ticket URL: <http://trac.xapian.org/ticket/303#comment:3>
Xapian <http://xapian.org/>
Xapian