#303: UUID functions missing on Windows
-------------------------------+--------------------------------------------
Reporter: charliejuggler | Owner: richard
Type: defect | Status: assigned
Priority: normal | Milestone: 1.1.0
Component: Backend-Flint | Version: SVN HEAD
Severity: normal | Resolution:
Keywords: | Blockedby:
Platform: Microsoft Windows | Blocking:
-------------------------------+--------------------------------------------
Comment(by olly):
The ChangeLog's are messed up oddly. Looks like your xapian-core
ChangeLog diff is against a copy of the msvc makefiles' ChangeLog with
conflicts in, and the new ChangeLog entry for xapian-core was added to the
the msvc makefiles' ChangeLog. But don't worry about that now - just bear
it in mind for the future.
One issue I can see - uuid_generate() isn't allowed to fail, but your
uuid_generate() won't generate a uuid if UuidCreate() doesn't return
RPC_S_OK (libuuid generates a time-based UUID if it can't generate a
network-address-based one). I think the main case here is a machine
without a network card though the MSDN docs are a bit confusing.
It sounds like Vista must always generates time based UUIDs, and it hints
that anything newer than 98 falls back to doing so without a network card,
but then why is RPC_S_UUID_NO_ADDRESS a possible return code?
The current handling is particularly bad as it will quietly use whatever
happens to be in the buffer already. If we can't sanely handle this,
throwing DatabaseCreateError() would be better I think, though that might
prevent creating a database at all on non-network systems...
--
Ticket URL: <http://trac.xapian.org/ticket/303#comment:9>
Xapian <http://xapian.org/>
Xapian