[Xapian-tickets] [Xapian] #359: MultiValueSorter::add() and Enquire::set_sort_by_value() inconsistency

Xapian nobody at xapian.org
Thu Apr 23 15:01:02 BST 2009

#359: MultiValueSorter::add() and Enquire::set_sort_by_value() inconsistency
 Reporter:  olly         |       Owner:  olly 
     Type:  defect       |      Status:  new  
 Priority:  normal       |   Milestone:  1.1.7
Component:  Library API  |     Version:  1.1.0
 Severity:  normal       |    Keywords:       
Blockedby:               |    Platform:  All  
 Blocking:               |  
 Daniel Menard in comment:ticket:311:15 points out:
 > Just a note to point out that the logic seems to be the opposite
 > for !MultiValueSorter:
 > !MultiValueSorter::add(Xapian::valueno valno, bool forward=true);
 > Enquire::set_sort_by_key(Xapian::Sorter *sorter, bool reverse=true);

 The default direction is good for MultiValueSorter::add(), but the
 parameter name is annoyingly inconsistent.

 Not sure I see a good fix other than renaming the class and/or method.

 Marking milestone:1.1.7 for now at least - we should either address this
 in the 1.1.x series, or decide the best option is not to.

Ticket URL: <http://trac.xapian.org/ticket/359>
Xapian <http://xapian.org/>

More information about the Xapian-tickets mailing list