[Xapian-tickets] [Xapian] #50: SynonymPostList

[Xapian]

#50: SynonymPostList
-------------------------+--------------------------------------------------
 Reporter:  olly         |        Owner:  richard  
     Type:  enhancement  |       Status:  assigned 
 Priority:  low          |    Milestone:  1.1.1    
Component:  Library API  |      Version:  SVN trunk
 Severity:  minor        |   Resolution:           
 Keywords:               |    Blockedby:           
 Platform:  All          |     Blocking:  104      
-------------------------+--------------------------------------------------

Comment(by richard):

 I've just gone through the coverage reports again for the changes made in
 the opsynonym branch (a little more carefully than last time I did this):

 There are 3 changes which have no coverage, which I do not propose to fix:

  - weight.cc line 92. This is only called if (stats_needed &
 DOC_LENGTH_MAX) is
    true, but this isn't the case for any weighting object existing in
 core.
    The equivalent line is also missed for all the other Weight::init_()
    methods.  The fix for all of these would be to write a test with a
 custom
    weight which used this.

  - synonympostlist.cc: SynonymPostList::get_weight() when (want_wdf) is
 false.
    Again, no this isn't true for any current weighting algorithm other
 than
    BoolWeight.

  - synonympostlist.cc: SynonymPostList::get_description().  This is only
 called
    from debugging code.

 There are also the following functions which I propose to try and add
 coverage for by writing further tests:

  - andmaybepostlist.cc: AndMaybePostList::get_wdf()
  - andnotpostlist.cc: AndNotPostList::get_wdf()
  - andpostlist.cc: AndPostList::get_wdf()
  - xorpostlist.cc: XorPostList::get_wdf()
  - synonympostlist.cc: SynonymPostList::skip_to()

 Other than writing these further tests, and assuming no problems show up
 when I write them, I think we're in a good position to merge to trunk.

-- 
Ticket URL: <http://trac.xapian.org/ticket/50#comment:30>
Xapian <http://xapian.org/>
Xapian