[Xapian-tickets] [Xapian] #327: Power Point 2007 Filter

Xapian nobody at xapian.org
Tue Feb 17 06:47:26 GMT 2009


#327: Power Point 2007 Filter
-------------------------+--------------------------------------------------
 Reporter:  frankjb      |        Owner:  olly  
     Type:  enhancement  |       Status:  new   
 Priority:  normal       |    Milestone:        
Component:  Other        |      Version:  1.0.10
 Severity:  normal       |   Resolution:        
 Keywords:               |    Blockedby:        
 Platform:  All          |     Blocking:        
-------------------------+--------------------------------------------------

Comment(by olly):

 Thanks for the patch, but...

 The patch tries to extract the notes and comments unconditionally, but you
 suggest in your comments that this doesn't work if they don't exist.  So
 I'm wondering if you've attached a different version of the patch to that
 you intended...

 Also (just like your earlier patch in ticket #290) this needs
 corresponding documentation updates and ideally some sample files to allow
 testing.  While I can update the documentation myself, I'm afraid I have
 more pressing things to work on currently, and I don't have any files in
 this format or the ability to create them myself.

 Worse, the patch is malformed so the "patch" program won't apply it - I
 think you must have produced it by hand from a patch including other
 changes, but that means that you haven't tested the patch as sent, and I
 can't test any attempt to apply it by hand as I don't have any example
 files!

 If the full patch just includes the changes in #290, it's fine to just put
 the full patch there instead of having a separate ticket for this
 addition.

-- 
Ticket URL: <http://trac.xapian.org/ticket/327#comment:1>
Xapian <http://xapian.org/>
Xapian



More information about the Xapian-tickets mailing list