#375: Merge postingsources branch
-------------------------+--------------------------------------------------
Reporter: olly | Owner: richard
Type: enhancement | Status: new
Priority: normal | Milestone: 1.1.2
Component: Library API | Version:
Severity: normal | Keywords:
Blockedby: | Platform: All
Blocking: |
-------------------------+--------------------------------------------------
Comment(by olly):
OK, I've just reviewed this diff between the branch and trunk:
{{{
#!sh
svn diff --old=. at 12771
--new=svn+userv:///xapian/branches/postingsources@HEAD
}}}
Comments:
* Test coverage for !DecreasingValueWeightPostingSource doesn't test a
restricted range starting at a docid other than 1.
* There's also no coverage for having more than one document in a row
with the same weight.
* I don't think we should add a new header to {{{include/xapian}}} for
every new class. These are subclasses of !PostingSource and can just go
in postingsource.h with the other subclasses of !PostingSource.
* !LimitedValueWeightPostingSource has no documentation comments and no
test coverage, but I think we decided it didn't have enough utility
outside of use with flint, and flint will be deprecated in 1.2.0, so I
guess you didn't bother with that deliberately?
* The tweak to not wrap in xapian-bindings/python/doxy2swig.py.in should
probably just drop the old version of the line rather than commenting it
out. If it's an issue to resolve, then it deserves a FIXME and
explanatory comment.
I was concerned we should try to merge branches right at the start of
working on a particular 1.1.x, but in this case it's only adding
functionality and doesn't really touch existing code, so it seems it's
only going to break itself at worst.
--
Ticket URL: <http://trac.xapian.org/ticket/375#comment:1>
Xapian <http://xapian.org/>
Xapian