[Xapian-tickets] [Xapian] #363: Avoid using the termlist when calculating percentages in get_mset()

Xapian nobody at xapian.org
Fri Jul 10 16:59:37 BST 2009


#363: Avoid using the termlist when calculating percentages in get_mset()
---------------------+------------------------------------------------------
 Reporter:  richard  |       Owner:  olly     
     Type:  defect   |      Status:  assigned 
 Priority:  normal   |   Milestone:  1.1.2    
Component:  Matcher  |     Version:  SVN trunk
 Severity:  normal   |    Keywords:           
Blockedby:           |    Platform:  All      
 Blocking:  181      |  
---------------------+------------------------------------------------------
Changes (by olly):

  * status:  new => assigned
  * milestone:  1.1.3 => 1.1.2


Comment:

 OK, I have a patch, and it passes the testsuite with changes to two tests:

   * topercent2 needs a tweak because we generate different percentages
   * synonym4 needs a tweak to disable a check that we attain 100% for
 OP_XOR of a term and a synonym of two terms.

 The former seems fine to me.

 As for the latter, unless I'm missing something, it's actually incorrect
 that we give 100% currently.  Or at least inconsistent - perhaps {{{a XOR
 b}}} should give 100% if the XOR matches, but it doesn't currently.

 Although the patch currently passes all tests, I think the remote case may
 need further work.  I don't think the testsuite cover multi of local and
 remote (we could add support for this as another multi variant, though the
 combinatorial explosion means we need to be careful about how exactly we
 do this...)  Comments are still welcome.

 Setting milestone to 1.1.2 since we have a patch of sorts - if we omit
 this from 1.1.2 it should be a concious choice.

-- 
Ticket URL: <http://trac.xapian.org/ticket/363#comment:7>
Xapian <http://xapian.org/>
Xapian



More information about the Xapian-tickets mailing list