[Xapian-tickets] [Xapian] #359: MultiValueSorter::add() and Enquire::set_sort_by_value() inconsistency

[Xapian]

#359: MultiValueSorter::add() and Enquire::set_sort_by_value() inconsistency
-------------------------+--------------------------------------------------
 Reporter:  olly         |       Owner:  olly    
     Type:  defect       |      Status:  assigned
 Priority:  highest      |   Milestone:  1.1.3   
Component:  Library API  |     Version:  1.1.0   
 Severity:  normal       |    Keywords:          
Blockedby:               |    Platform:  All     
 Blocking:               |  
-------------------------+--------------------------------------------------

Comment(by richard):

 Having the same base class for building keys for sorting or collapsing
 sounds like a sensible approach to me - if collapsing by binary comparison
 isn't desirable for some reason, it seems likely that collapsing by items
 which sort as equal will be.

 !KeyMaker seems a reasonable name to me.  We'd:
  - add a KeyMaker base class.
  - make Sorter a subclass of this, to allow API compatibility.
  - deprecate Sorter and MultiValueSorter.
  - add a MultiValueKeyMaker class with the desired semantics for its
 add_value() method.

-- 
Ticket URL: <http://trac.xapian.org/ticket/359#comment:5>
Xapian <http://xapian.org/>
Xapian