[Xapian-tickets] [Xapian] #325: flint_table.cc uses zlib inefficiently

[Xapian]

#325: flint_table.cc uses zlib inefficiently
---------------------------+------------------------------------------------
 Reporter:  tlipcon        |        Owner:  richard  
     Type:  enhancement    |       Status:  closed   
 Priority:  normal         |    Milestone:  1.1.0    
Component:  Backend-Flint  |      Version:  SVN trunk
 Severity:  normal         |   Resolution:  fixed    
 Keywords:                 |    Blockedby:           
 Platform:  All            |     Blocking:           
---------------------------+------------------------------------------------
Changes (by richard):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 Applied a slightly modified version of  Refactor-zlib-usage-in-FlintTable-
 and-ChertTable-to-avoid-reallocat.3.patch to head (in r12018).
 Differences were:

  - Add Todd to AUTHORS.
  - don't make the destructors virtual.
  - Put back the "Deflate failed" comment.
  - ignore errors from inflateEnd() and deflateEnd()  (with cast to void)

 Then realised I forgot to update the doccomments, so added them in r12019.

 I think the laziness is worthwhile - in particular, if you don't write to
 the table, it means that the deflate zstream never gets created, which is
 nice.

 Marking this as fixed - it could probably usefully be backported to 1.0.x,
 but this will get done in the normal course of going through 1.1 checking
 for backport candidates.

-- 
Ticket URL: <http://trac.xapian.org/ticket/325#comment:7>
Xapian <http://xapian.org/>
Xapian