[Xapian-tickets] [Xapian] #448: Allow usage of custom stemmers

[Xapian]

#448: Allow usage of custom stemmers
-------------------------+--------------------------------------------------
 Reporter:  esizikov     |        Owner:  olly    
     Type:  enhancement  |       Status:  reopened
 Priority:  normal       |    Milestone:  1.2.x   
Component:  Library API  |      Version:  1.0.17  
 Severity:  normal       |   Resolution:          
 Keywords:               |    Blockedby:          
 Platform:  All          |     Blocking:          
-------------------------+--------------------------------------------------

Comment(by olly):

 Actually, trac does notify for attaching a patch, but I'm afraid I've just
 been acutely short of time recently.

 A quick review:

  * It's better not to make whitespace changes (wrapping some long lines)
 in the same patch as functional changes - it makes reviewing harder as the
 reviewer has to compare the wrapped and unwrapped versions to see if there
 are actually also functional changes there or not.  One logical change per
 patch is greatly preferable.

  * {{{Stem::Internal::Implementation}}}'s empty default constructor
 doesn't seem to be needed.

  * In comment:13 and comment:14 we discussed going with
 {{{Xapian::StemImplementation}}} but you haven't after all.  Instead
 you've added a preprocessor check for SWIG in the API headers which seems
 the wrong approach.  Firstly, we want to avoid SWIG-specific logic here,
 but more importantly we want SWIG to see the "stem implementation" class
 so that it will wrap it and allow it to be subclassed in Python (or
 whatever) by a user wanting to implement a stemmer.

-- 
Ticket URL: <http://trac.xapian.org/ticket/448#comment:16>
Xapian <http://xapian.org/>
Xapian