[Xapian-tickets] [Xapian] #518: xapian-compact: error output does not state source of evil

[Xapian]

#518: xapian-compact: error output does not state source of evil
---------------------------+------------------------------------------------
 Reporter:  luxitude       |        Owner:  olly     
     Type:  defect         |       Status:  closed   
 Priority:  normal         |    Milestone:           
Component:  Backend-Flint  |      Version:  1.2.3    
 Severity:  critical       |   Resolution:  duplicate
 Keywords:                 |    Blockedby:           
 Platform:  All            |     Blocking:           
---------------------------+------------------------------------------------
Changes (by olly):

  * status:  new => closed
  * platform:  Linux => All
  * version:  => 1.2.3
  * resolution:  => duplicate


Old description:

> In case xapian-compact is provided multiple source flint files and one of
> them contains a database corruption, the error message does not state the
> source file:
>
> ./usr/bin/xapian-compact: DatabaseCorruptError: Unexpected end of table
> when reading continuation of tag
>
> In the use case at hand, a periodic merge of about 200 partial xapian
> db's is done using xapian-compact overnight; the error message makes
> troubleshooting harder than it should be, because it doesn't state the
> source of evil. Sure this can be figured using strace and friends,
> however, it shouldn't be difficult to patch the error message to read
> instead:
>
> ./usr/bin/xapian-compact: DatabaseCorruptError: Unexpected end of table
> when reading continuation of tag in source database <whatever>.
>
> Binary: xapian-compact - xapian-core 1.2.3
> OS: Debian Stable, amd64

New description:

 In case xapian-compact is provided multiple source flint files and one of
 them contains a database corruption, the error message does not state the
 source file:

 {{{
 ./usr/bin/xapian-compact: DatabaseCorruptError: Unexpected end of table
 when reading continuation of tag
 }}}

 In the use case at hand, a periodic merge of about 200 partial xapian db's
 is done using xapian-compact overnight; the error message makes
 troubleshooting harder than it should be, because it doesn't state the
 source of evil. Sure this can be figured using strace and friends,
 however, it shouldn't be difficult to patch the error message to read
 instead:

 {{{
 ./usr/bin/xapian-compact: DatabaseCorruptError: Unexpected end of table
 when reading continuation of tag in source database <whatever>.
 }}}

 Binary: xapian-compact - xapian-core 1.2.3
 OS: Debian Stable, amd64

--

Comment:

 Hi, thanks for your bug report.

 I don't think this is can be specific to compaction since this message
 comes from the backend level - it appears one of your input databases is
 corrupt (you only happen to notice this during compaction because
 compacting tries to copy all the entries whereas any search only looks at
 a small number of them).  Currently the easiest way to check which is to
 run xapian-check on each of them.

 We already have a ticket for the issue that exceptions often don't mention
 the database involved (#329) so I'm closing this ticket as a duplicate of
 that existing ticket.

 If all your inputs are OK by xapian-check, please reopen this ticket.

-- 
Ticket URL: <http://trac.xapian.org/ticket/518#comment:1>
Xapian <http://xapian.org/>
Xapian