[Xapian-tickets] [Xapian] #434: reopen should re-read stub database file

Xapian nobody at xapian.org
Tue Feb 2 21:32:21 GMT 2010

#434: reopen should re-read stub database file
 Reporter:  richard      |       Owner:  richard  
     Type:  defect       |      Status:  assigned 
 Priority:  normal       |   Milestone:  1.2.x    
Component:  Library API  |     Version:  SVN trunk
 Severity:  normal       |    Keywords:           
Blockedby:               |    Platform:  All      
 Blocking:               |  

Comment(by olly):

 The patch fails the test for a short write() in write_stub(), which is
 likely to cause tests to fail for some platforms with some sizes of stub
 data, and could potentially cause random test failures.  That really needs

 I'm sure we must already have code to reliably create a stub file
 elsewhere in the testsuite.

 Also, if you're going to add the same document repeatedly in a loop to
 build a database, create the Document object just once outside the loop.
 The point is to create the database for the
 tests we want to perform, not to test database creation, and the testsuite
 is already too slow.  Needlessly creating and destroying an extra 2997
 Document objects is overhead best avoided.

Ticket URL: <http://trac.xapian.org/ticket/434#comment:6>
Xapian <http://xapian.org/>

More information about the Xapian-tickets mailing list