[Xapian-tickets] [Xapian] #239: makedepend gets confused with multiple #include "filename..." in same program

[Xapian]

#239: makedepend gets confused with multiple #include "filename..." in same
program
-------------------------------+--------------------------------------------
 Reporter:  caa                |        Owner:  caa      
     Type:  defect             |       Status:  reopened 
 Priority:  normal             |    Milestone:  1.0.19   
Component:  MSVC makefiles     |      Version:  SVN trunk
 Severity:  major              |   Resolution:           
 Keywords:                     |    Blockedby:           
 Platform:  Microsoft Windows  |     Blocking:           
-------------------------------+--------------------------------------------
Changes (by olly):

 * cc: olly (removed)
  * milestone:  => 1.0.19


Comment:

 In normal make it should make no difference whether the prerequisites are
 one per rule or many per rule, but nmake does sometimes seem to be oddly
 different.  And splitting them should avoid any issues with limited line
 length.

 Applied the patch with a couple of tweaks in r14148.

 I avoided appending a string to objfile which might overflow it, and
 instead just write it to the output each time in the loop below.

 GCC warns about a construct in your copying loop - I think it is undefined
 behaviour because ch on the LHS could be evaluated before, after, or
 concurrently with ch++ on the right (isn't C lovely?):

 {{{
 #!c
 objfile[ch] = buf[ch++];
 }}}

 So I've tweaked that to be a for loop with the increment separate.

 I'm reluctant to commit unused files as they'll bloat every checkout a
 bit, and sooner or later will end up out of sync.  Let's just decree the
 nmake file as the supported way to build.  If anyone really wants a
 project file they can create one easily enough.

 So unless I broke something, this is ready for backporting.

-- 
Ticket URL: <http://trac.xapian.org/ticket/239#comment:17>
Xapian <http://xapian.org/>
Xapian