[Xapian-tickets] [Xapian] #481: Merge geospatial branch
Xapian
nobody at xapian.org
Thu May 20 10:34:55 BST 2010
#481: Merge geospatial branch
-------------------------+--------------------------------------------------
Reporter: richard | Owner: richard
Type: enhancement | Status: assigned
Priority: normal | Milestone: 1.2.1
Component: Library API | Version: SVN trunk
Severity: normal | Keywords:
Blockedby: | Platform: All
Blocking: |
-------------------------+--------------------------------------------------
Comment(by richard):
Code coverage is fairly good, except for the PostingSource which has no
coverage of the skip_to() and check() methods. I'll try and find time to
write some tests to cover those soon, but other than that I think this
patch is a pretty good candidate for pushing to trunk.
One potential API addition you might not be keen on, is in
include/xapian/postingsource.h, where I've added a
{{{
virtual PostingSource * unserialise_with_registry(const std::string &s,
const Registry & registry) const;
}}}
method. I think we need this method, but the name is a bit horrible:
unlike the Query::unserialise() method, we can't just overload the
unserialise() method with a variant which takes the registry, because this
doesn't work with inheritance (as far as I can see). Any better ideas
welcome, but I don't think this is too horrible an API to live with.
--
Ticket URL: <http://trac.xapian.org/ticket/481#comment:5>
Xapian <http://xapian.org/>
Xapian
More information about the Xapian-tickets
mailing list