[Xapian-tickets] [Xapian] #530: Updated makefiles for MSVC - trunk for 1.2.4

[Xapian]

#530: Updated makefiles for MSVC - trunk for 1.2.4
----------------------------+-----------------------------------------------
 Reporter:  charliejuggler  |       Owner:  charliejuggler   
     Type:  defect          |      Status:  new              
 Priority:  normal          |   Milestone:                   
Component:  MSVC makefiles  |     Version:  SVN trunk        
 Severity:  normal          |    Keywords:                   
Blockedby:                  |    Platform:  Microsoft Windows
 Blocking:                  |  
----------------------------+-----------------------------------------------

Comment(by olly):

 Hmm, the patch seems to include a number of changes that seem a bit
 peculiar, and some which seem unlikely to be intended.

 Going through the files:

 xapian-applications/omega/diritor.h - applied with minor tweaks, though
 it'd be nicer to return the file's owner (seems to require use of win32
 API calls from what I can see).  r15289.

 xapian-core/api/compactor.cc - we're using the C++ versions of standard C
 headers (except where there is a good reason not to), so that added
 {{{#include <ctime>}}} instead.  r15290.

 xapian-maintainer-tools/win32msvc/ChangeLog - this patch seems very messed
 up, so not applied.  It's a really good idea to at least skim through the
 generated patch for reasonableness before sending it in.

 xapian-maintainer-tools/win32msvc/config.h.win32 - it's silly to be
 defining and setting the euid member on platforms where we aren't going to
 be using it, which simplifies the patch needed here.  Setting PKGLIBBINDIR
 to "" isn't a good plan - this means that helpers will be looked for in
 the root directory of the current drive, which isn't desirable and could
 perhaps even be a security concern.  If there isn't a good default, we
 should throw an exception if XAPIAN_OMEGA_PKGLIBBINDIR isn't set in the
 environment.  The readability tests are currently pointless if we can't
 get the file's owner, so perhaps there's a cleaner way of dealing with
 that - I will ponder that.

 xapian-maintainer-tools/win32msvc/config.h.win32 - OK.

 xapian-maintainer-tools/win32msvc/config.mak - seems to rather arbitrarily
 change paths (or quoting of paths) for omega, python 3, php stuff - is
 that intended?  Not applied.

 xapian-maintainer-tools/win32msvc/README - "Xapian trunk 1.2.4" should
 probably just be "Xapian 1.2.4" - applied with that change in r15294.

 xapian-maintainer-tools/win32msvc/win32_applications_omega.mak - another
 path change which I wonder about.  Not applied for now.

 xapian-maintainer-tools/win32msvc/win32_bindings_php.mak - seems to no
 longer clean up some files which might well be produced - is that meant?

 xapian-maintainer-tools/win32msvc/win32_bindings_python.mak - seems to be
 removing support for Python 3...

 xapian-maintainer-tools/win32msvc/win32_expand.mak and xapian-maintainer-
 tools/win32msvc/win32_unicode.mak just seem to be removing newlines at the
 end of the file, which seems unhelpful if anything, so I didn't apply
 those.

 I applied the remaining makefile changes in r15295.

-- 
Ticket URL: <http://trac.xapian.org/ticket/530#comment:1>
Xapian <http://xapian.org/>
Xapian