[Xapian-tickets] [Xapian] #278: When changesets are being generated, old changesets aren't cleaned up

[Xapian]

#278: When changesets are being generated, old changesets aren't cleaned up
---------------------------+------------------------------------------------
 Reporter:  richard        |       Owner:  dcolish  
     Type:  defect         |      Status:  assigned 
 Priority:  low            |   Milestone:  1.2.x    
Component:  Backend-Chert  |     Version:  SVN trunk
 Severity:  normal         |    Keywords:           
Blockedby:                 |    Platform:  All      
 Blocking:                 |  
---------------------------+------------------------------------------------

Comment(by olly):

 Looks good to me, but a few nits:

 brass:

 Comment typo - "being" -> "begin".

 Another case where we might delete multiple changeset files is if the
 value of max_changesets is reduced by the user (for the comment).

 I think this will try to delete changeset0 the first time, which is fairly
 harmless but easy to avoid.

 stop_changeset should be brass_revision_number_t not unsigned.

 I'd just call the methods on the stats member directly rather than adding
 another two private methods to !BrassDatabase which only get called from
 one place.

 chert and flint:

 "changset" -> "changeset" in comment.

 testcase:

 A simpler (and clearer) check for the changeset not existing is:

 {{{
 #!cpp
     TEST(!file_exists(masterpath + "/changes1");
 }}}

 Also might be good to test that if you reduce max_changesets then the
 intervening ones also get removed (e.g. set max to 4, commit 5 changes,
 check that the first one got removed, reduce max to 2, commit a change,
 and check that the last 2 changesets exist but the 3 before that don't).

-- 
Ticket URL: <http://trac.xapian.org/ticket/278#comment:15>
Xapian <http://xapian.org/>
Xapian