[Xapian-tickets] [Xapian] #576: xapian.php from 1.2.7 causes php notices

[Xapian]

#576: xapian.php from 1.2.7 causes php notices
-----------------------------------+----------------------------------------
 Reporter:  Dougle                 |        Owner:        
     Type:  defect                 |       Status:  closed
 Priority:  normal                 |    Milestone:  1.2.8 
Component:  Xapian-bindings (PHP)  |      Version:  1.2.7 
 Severity:  minor                  |   Resolution:  fixed 
 Keywords:                         |    Blockedby:        
 Platform:  All                    |     Blocking:        
-----------------------------------+----------------------------------------
Changes (by olly):

  * status:  new => closed
  * resolution:  => fixed
  * milestone:  => 1.2.8


Old description:

> [11-Nov-2011 12:49:51] PHP Notice:  Undefined variable: r in xapian.php
> on line 3129
> [11-Nov-2011 12:49:51] PHP Notice:  Undefined variable: r in xapian.php
> on line 3137

New description:

 {{{
 [11-Nov-2011 12:49:51] PHP Notice:  Undefined variable: r in xapian.php on
 line 3129
 [11-Nov-2011 12:49:51] PHP Notice:  Undefined variable: r in xapian.php on
 line 3137
 }}}

--

Comment:

 I fixed this issue in SWIG a while back and updated trunk to using the
 latest SWIG to generate the bindings (and a regression test was added in
 r15934).  1.2 branch also got a newer SWIG with this fix, but after 1.2.7
 was released (I can't seem to get it to tell me just when svn:externals
 was updated, but these bogus {{{return $r;}}} statements are gone on the
 tip of the 1.2 branch.

 So this is already fixed ready for 1.2.8, and I've just backported the
 regression test too (r16123) to ensure this stays fixed.

-- 
Ticket URL: <http://trac.xapian.org/ticket/576#comment:1>
Xapian <http://xapian.org/>
Xapian