[Xapian-tickets] [Xapian] #563: Add a mode for indexing only stemmed terms in TermGenerator
Xapian
nobody at xapian.org
Mon Apr 16 07:05:20 BST 2012
#563: Add a mode for indexing only stemmed terms in TermGenerator
-------------------------+--------------------------------------------------
Reporter: vitalif | Owner: olly
Type: enhancement | Status: new
Priority: normal | Milestone: 1.3.x
Component: QueryParser | Version: 1.2.6
Severity: normal | Keywords:
Blockedby: | Platform: All
Blocking: |
-------------------------+--------------------------------------------------
Old description:
> Many search engines just index stems and throw away exact terms. This may
> be convenient if you don't need searching for exact terms, and it greatly
> reduces the index.
> It would be good for TermGenerator to have such indexing mode.
New description:
Many search engines just index stems and throw away exact terms. This may
be convenient if you don't need searching for exact terms, and it greatly
reduces the index.
It would be good for !TermGenerator to have such indexing mode.
--
Comment(by olly):
Thanks for the patch. It looks pretty good to me, but a few comments:
Some test coverage for the new modes would be good - we already have tests
for the existing STEM_xxx modes in tests/queryparsertest.cc, and for the
now default (previously only) stemming mode of !TermGenerator in
tests/termgentest.cc.
It's better to just write {{{string stem;}}} rather than {{{string
stem("");}}} since std::string objects are empty by default, and the
compiler can special case default initialisation and handle it more
efficiently (GCC does, I haven't looked at other compilers closely).
And a couple of style issues:
Please put a space after keywords followed by an opening bracket (so {{{if
(foo)}}} not {{{if(foo)}}}) to distinguish them more clearly visually from
function calls.
For Xapian code, we use 4 space indent, tab filled with a tab being 8
spaces wide - I think your editor has tabs as 4 spaces wide - the
indentation of some of the changed lines is too deep with the standard
settings anyway.
--
Ticket URL: <http://trac.xapian.org/ticket/563#comment:3>
Xapian <http://xapian.org/>
Xapian
More information about the Xapian-tickets
mailing list