[Xapian-tickets] [Xapian] #607: Handle second and third argument to Xapian::StringValueRangeProcessor new() in Perl bindings
Xapian
nobody at xapian.org
Mon Oct 1 02:55:49 BST 2012
#607: Handle second and third argument to Xapian::StringValueRangeProcessor new()
in Perl bindings
----------------------------+-----------------------------------------------
Reporter: asjo | Owner: olly
Type: defect | Status: new
Priority: normal | Milestone: 1.2.13
Component: Search::Xapian | Version: 1.2.12
Severity: normal | Keywords:
Blockedby: | Platform: All
Blocking: |
----------------------------+-----------------------------------------------
Changes (by olly):
* version: => 1.2.12
* milestone: => 1.2.13
Comment:
We ask for a dual licence on contributed patches, not just GPLv2+:
http://trac.xapian.org/browser/trunk/xapian-core/HACKING#L1231
In this particular case, the XS changes would only be relevant for 1.2.x
as trunk has SWIG-based Perl bindings (which should wrap these optional
arguments already), but the documentation change and any testsuite changes
would likely be useful for trunk too.
Looking at the patch, I think passing 2 arguments should be valid too, not
just 1 or 3.
A simple feature test to make sure the Perl wrapper does now accept 3 (or
2) arguments and still accepts 1 would be good, and would also help to
ensure this is compatible with trunk. I can probably write one if
necessary, though that's likely to delay getting this applied - a
corresponding testsuite change would be very welcome.
--
Ticket URL: <http://trac.xapian.org/ticket/607#comment:1>
Xapian <http://xapian.org/>
Xapian
More information about the Xapian-tickets
mailing list