[Xapian-tickets] [Xapian] #643: blocksize1 test needs db.close()

[Xapian]

#643: blocksize1 test needs db.close()
------------------------+--------------------------------------
 Reporter:  cco         |             Owner:  olly
     Type:  defect      |            Status:  closed
 Priority:  normal      |         Milestone:  1.2.18
Component:  Test Suite  |           Version:  1.2.17
 Severity:  normal      |        Resolution:  fixed
 Keywords:              |        Blocked By:
 Blocking:              |  Operating System:  Microsoft Windows
------------------------+--------------------------------------
\
\
\
\
Changes (by olly):

 * status:  new => closed
 * resolution:   => fixed
 * milestone:   => 1.2.18

\
\
\

Comment:

 Thanks.

 I've fixed this in the 1.2 branch in r18050.  I've gone for making the
 {{{WritableDatabase}}} object have the scope of the loop block, so its
 destructor gets called at the end of the block, so an explicit close
 shouldn't be needed.  This approach more closely matches how the code
 already is on trunk, and minimising differences tends to make backporting
 patches simpler.

 This fix should be in 1.2.18.

 BTW, a patch file is preferable to trying to describe which lines to
 change - there are some tips on generating them in this paragraph of
 HACKING:

 http://trac.xapian.org/browser/trunk/xapian-core/HACKING#L1160
\
\
\

--
Ticket URL: <http://trac.xapian.org/ticket/643#comment:1>
Xapian <http://xapian.org/>
Xapian