[Xapian-tickets] [Xapian] #632: ACL support for omindex

[Xapian]

#632: ACL support for omindex
-------------------------+-----------------------------
 Reporter:  egarette     |             Owner:  olly
     Type:  enhancement  |            Status:  assigned
 Priority:  normal       |         Milestone:  1.4.x
Component:  Omega        |           Version:
 Severity:  normal       |        Resolution:
 Keywords:               |        Blocked By:
 Blocking:               |  Operating System:  All
-------------------------+-----------------------------
Changes (by olly):

 * milestone:  1.3.5 => 1.4.x


Comment:

 > > It would also be good to have some some tests for this, which create
 some files and set up ACLs on them, index them, and check the results of
 filtering match what they should.
 >
 > I did not even look at your test infrastructure but I would suggest a
 patch soon

 Sadly we don't have any indexing tests of omindex currently.  In git
 master we have the relatively new `omegatest` which runs some tests on the
 `omega` CGI, but currently all of these run with empty database (the
 current tests are mostly about how the CGI parameters are turned into a
 `Xapian::Query` object).  So the test infrastructure for the indexing part
 of this doesn't currently exist, but it would be good to have such
 infrastructure so adding tests was possible.  And `omegatest` needs a
 small tweak to allow using use a built database instead of an empty one.

 I've been rather busy I'm afraid and haven't got to digging out my SMB ACL
 patch to compare yet.

 It's also occurred to me that this would be an optional feature (if you're
 not interested in checking ACLs, there's no point wasting effort indexing
 them or filtering by them), so rather than blocking 1.4.0 on merging this
 I think it makes more sense to target this to be merged in an early 1.4.x
 release.

 Also, have you already agreed to the patch licensing requirements:

 https://trac.xapian.org/browser/trunk/xapian-core/HACKING#L1364

--
Ticket URL: <https://trac.xapian.org/ticket/632#comment:9>
Xapian <//xapian.org/>
Xapian