[Xapian-tickets] [Xapian] #749: configure does not fail if sphinx is missing in Python 2

[Xapian]

#749: configure does not fail if sphinx is missing in Python 2
---------------------------------------------+--------------------
        Reporter:  ppaez                     |      Owner:
            Type:  defect                    |     Status:  new
        Priority:  normal                    |  Milestone:
       Component:  Xapian-bindings (Python)  |    Version:  1.4.3
        Severity:  normal                    |   Keywords:  Python
      Blocked By:                            |   Blocking:
Operating System:  Linux                     |
---------------------------------------------+--------------------
 `./configure --with-python` does not stop after checking for sphinx and
 finding that sphinx is not found.  The execution of `configure` ends in
 this message:
 {{{
 *** Not found the required tools for building bindings for any
 *** supported language!
 ***
 *** You may need to install -dev or -devel packages for the languages
 *** you want to build bindings for.
 ***
 *** For details of how to point configure at tools not on PATH, see:
 ***     ./configure --help
 }}}
 The correct behavior should be to issue this message and stop, similar to
 Python 3:
 {{{
 configure: error: Couldn't import sphinx module and call sphinx.main() for
 Python2 - try package python-sphinx
 }}}
 This issue was introduced inadvertently in commit
 723eae9daf6f89d865f667c10921f57201f66941 dated December 6th, 2016.

 The following patch was tested in Debian stretch and fixes the issue:
 {{{
 pp at g6:~/Downloads/src/xapian$ diff -Naur xapian-
 bindings/configure.ac{-ori,}
 --- xapian-bindings/configure.ac-ori    2017-04-01 19:32:40.069217157
 -0500
 +++ xapian-bindings/configure.ac        2017-04-01 20:29:58.515855408
 -0500
 @@ -356,7 +356,7 @@
        AC_MSG_RESULT([yes])
      else
        AC_MSG_RESULT([no])
 -      if test yes = "$with_python2" ; then
 +      if test yes = "$with_python" ; then
         AC_MSG_ERROR([Couldn't import sphinx module and call sphinx.main()
 for Python2 - try package python-sphinx])
        fi
        PYTHON2=
 }}}

 Regards,

 Patricio

--
Ticket URL: <https://trac.xapian.org/ticket/749>
Xapian <https://xapian.org/>
Xapian