[Xapian-tickets] [Xapian] #757: Testcase qp_scale1 fails consistently with --enable-log (was: Testcase qp_scale1 fails consistently)
Xapian
nobody at xapian.org
Mon Jun 25 05:33:32 BST 2018
#757: Testcase qp_scale1 fails consistently with --enable-log
------------------------+-----------------------------
Reporter: gp1308 | Owner: olly
Type: defect | Status: assigned
Priority: low | Milestone: 1.4.6
Component: Test Suite | Version:
Severity: normal | Resolution:
Keywords: | Blocked By:
Blocking: | Operating System: All
------------------------+-----------------------------
Changes (by olly):
* cc: olly (removed)
* status: new => assigned
* component: Other => Test Suite
* milestone: => 1.4.6
Comment:
> The logging certainly can cause issues - e.g. it can turn a method which
takes a `Query` object from `O(1)` to `O(n)` by calling
`Query::get_description()` when it logs the parameter value.
This is unfortunate, but seems hard to avoid as creating a query object's
description is inherently `O(n)` for a description which fully describes
the object.
I think we probably need to disable scaling tests when `--enable-log` is
used (not ideal but better than them failing) or somehow make them "soft
fail" (not ideal either).
We already have an `AUTOMATED_TESTING` check which skips timed tests like
these (because it's really unhelpful for an automated build to fail its
tests due to external factors such as abnormal load from other processes
on the machine), so enable-log could just hook into that.
Marking for 1.4.6.
--
Ticket URL: <https://trac.xapian.org/ticket/757#comment:4>
Xapian <https://xapian.org/>
Xapian
More information about the Xapian-tickets
mailing list