[Xapian-tickets] [Xapian] #743: omindex: delay libmagic checks

Xapian nobody at xapian.org
Thu Apr 4 15:20:28 BST 2019


#743: omindex: delay libmagic checks
--------------------+-------------------------------
 Reporter:  olly    |             Owner:  barufa
     Type:  defect  |            Status:  new
 Priority:  normal  |         Milestone:  1.4.x
Component:  Omega   |           Version:  git master
 Severity:  normal  |        Resolution:
 Keywords:          |        Blocked By:
 Blocking:          |  Operating System:  All
--------------------+-------------------------------

Comment (by barufa):

 > But unfortunately there aren't any tests for this area of omindex
 currently. There are unit tests for some functionality it uses, but
 nothing for the handling of files.

 I have made some changes in the code and `make check` seems to pass all
 the tests. However, prepare some tests for handling of files will take me
 a while.

 It would be great if you can take a look at the changes (honestly I am not
 sure modifying the code properly). Is it okay if I make a pull request? Or
 do you prefer to see it from my
 [https://github.com/barufa/xapian/tree/743_delay_libmagic_checks brach] ?

--
Ticket URL: <https://trac.xapian.org/ticket/743#comment:9>
Xapian <https://xapian.org/>
Xapian



More information about the Xapian-tickets mailing list