[Xapian-tickets] [Xapian] #785: Use std::string_view whenever possible

Xapian nobody at xapian.org
Sat May 4 06:59:39 BST 2019


#785: Use std::string_view whenever possible
-------------------------+-------------------------
 Reporter:  Kronuz       |             Owner:  olly
     Type:  enhancement  |            Status:  new
 Priority:  normal       |         Milestone:
Component:  Other        |           Version:
 Severity:  normal       |        Resolution:
 Keywords:               |        Blocked By:
 Blocking:               |  Operating System:  All
-------------------------+-------------------------

Comment (by olly):

 https://en.cppreference.com/w/cpp/compiler_support suggests that to rely
 on `std::string_view` being available would require GCC >= 7, Clang >= 4
 or MSVC 2017 (and probably not supporting any other compilers, though
 those are at least probably the current top 3).  That means you couldn't
 build with the system compiler on Debian stretch (the current stable
 release, though a new one is in freeze currently) or Ubuntu xenial (which
 is the newest travis-ci currently offers).

 So bear in mind that's significantly more aggressive in terms of compiler
 requirements than we've ever previously been.

 I'm not totally ruling it out as a possibility, but I think you need to
 demonstrate that we could deliver '''significant''' performance
 improvements (just being '''measurable''' is rather a low bar).

 Or is there a way we could use `std::string_view` if available, but fall
 back if not?

--
Ticket URL: <https://trac.xapian.org/ticket/785#comment:1>
Xapian <https://xapian.org/>
Xapian



More information about the Xapian-tickets mailing list