From nobody at xapian.org Wed Jan 6 17:40:07 2021 From: nobody at xapian.org (Xapian) Date: Wed, 06 Jan 2021 17:40:07 -0000 Subject: [Xapian-tickets] [Xapian] #806: Project does not compile on VS2019 with C++20 turned on In-Reply-To: <036.daa00efeab4c7d16c547e6bb2a23cef0@xapian.org> References: <036.daa00efeab4c7d16c547e6bb2a23cef0@xapian.org> Message-ID: <051.ce80e278b78f077fc7df0e7d6a9a04cd@xapian.org> #806: Project does not compile on VS2019 with C++20 turned on --------------------------+-------------------------------------- Reporter: Mateusz Pusz | Owner: Olly Betts Type: defect | Status: new Priority: normal | Milestone: Component: Other | Version: 1.4.16 Severity: normal | Resolution: Keywords: | Blocked By: Blocking: | Operating System: Microsoft Windows --------------------------+-------------------------------------- Changes (by Olly Betts): * milestone: 1.4.18 => Comment: I've removed the 10 remaining uses of `using namespace std;` from headers on git master in d5fb8bfde7481483e0793c08715cb84212e1b1eb, and added a check for this to the patch checking script to catch people trying to add new instances in 5a1df9067e1cd1207acee31839727955dad257b0. However the patch to remove the uses on master is large: > 33 files changed, 171 insertions(+), 168 deletions(-) And the 1.4 branch has nearly twice as many remaining uses - eliminating them all just seems too invasive a change to make several years into a stable release branch. As above, a targetted patch to address this is welcome, but I'm not easily able to work on one as this just isn't a platform I use. Unsetting the milestone for now since 1.4.18 is overdue and this can presumably be worked around by just specifying a lower standards version to the compiler. -- Ticket URL: Xapian Xapian