[Xapian-tickets] [Xapian] #808: msys64 CPPFLAGS=-D_FORTIFY_SOURCE=[2, 1] did not build

[Xapian]

#808: msys64 CPPFLAGS=-D_FORTIFY_SOURCE=[2,1] did not build
--------------------------+--------------------------------------
 Reporter:  xpbxf4        |             Owner:  Olly Betts
     Type:  defect        |            Status:  closed
 Priority:  normal        |         Milestone:  1.4.23
Component:  Build system  |           Version:  1.4.18
 Severity:  normal        |        Resolution:  fixed
 Keywords:  gcc FORTIFY   |        Blocked By:
 Blocking:                |  Operating System:  Microsoft Windows
--------------------------+--------------------------------------
Changes (by Olly Betts):

 * status:  reopened => closed
 * resolution:   => fixed

Comment:

 Backported that as 08142926809a4baa31dc5c9a357093efc7e9a45c.

 However I then found this doesn't work as intended either.

 The problem is that including a header to check if we're on mingw-w64
 results in processing the current _FORTIFY_SOURCE setting, and we can't
 then usefully change it based on whether we're on mingw-w64 or not.

 I've pushed a change to just not auto-enabling _FORTIFY_SOURCE on mingw or
 mingw-w64.  It doesn't work on the latter without -lssp, and I can't find
 evidence it's even supported on the former anyway.  If it is, enabling
 manually will still work.

 That's 424f7b33a00bb41b6b05056a8a9c8a4bdee38b1d, backported as
 85b67415ce2f076b684c91112fddcf522c615efb.
-- 
Ticket URL: <https://trac.xapian.org/ticket/808#comment:7>
Xapian <https://xapian.org/>
Xapian