[Xapian-devel] Re: [Xapian-commits] 8181: trunk/xapian-bindings/ trunk/xapian-bindings/python/

Olly Betts olly at survex.com
Wed Apr 11 11:19:22 BST 2007


On Wed, Apr 11, 2007 at 10:31:39AM +0100, richard wrote:
> python/smoketest.py: Replace cut-and-pasted test checking code
> with functions, to simplify tests.

It might be simpler, but mostly because functionality has gone - you've
thrown away all my carefully written failure messages!

Now if a test fails, the message is very generic and you have to read
the code to find out what's wrong.  This makes handling user reports of
test failures harder, since the line numbers reported may be different
in the version they're using (and the exact version is frequently not
mentioned in initial problem reports).

It'll also be easier to keep the different language versions of the
smoketest in step if we resist the urge to mercilessly refactor them
individually...

Cheers,
    Olly



More information about the Xapian-devel mailing list