[Xapian-devel] ExpandDecider and MatchDecider operator() return type

James Aylett james-xapian at tartarus.org
Fri Apr 20 12:50:13 BST 2007


On Fri, Apr 20, 2007 at 08:27:57AM +0100, Richard Boulton wrote:

> >I propose this should change in 1.0.  We'll have to skip deprecating the
> >old way, but updating is easy (just change 'int' to 'bool') and any
> >existing code which needs changing will give a pretty clear error, e.g.
> >GCC 4.1 reports:
> 
> I think this is reasonable - it should change at some point, and 1.0 is 
> the only sensible time in the near future.

+1

> If we did want to follow the deprecation policy, the only way to do it 
> that I can think of would be to introduce a whole new hierarchy of 
> MatchDecider classes, called, say, "MatchDecider2", which have a 
> different method signature, and overload the get_mset() method to take 
> one of these instead.  Which seems rather cumbersome, and leaves us with 
> a silly name for the class even after 1.1  (I suppose at that point we 
> could rename MatchDecider2, and deprecate the old one, so it wouldn't be 
> until release 1.2 that we have the state we're aiming for.)

-1

Just do it.

J

-- 
/--------------------------------------------------------------------------\
  James Aylett                                                  xapian.org
  james at tartarus.org                               uncertaintydivision.org



More information about the Xapian-devel mailing list