[Xapian-devel] Re: [Xapian-commits] 7817: trunk/xapian-core/ trunk/xapian-core/common/

[Olly Betts]

On Fri, Mar 02, 2007 at 09:14:56AM +0000, Richard Boulton wrote:
> Olly Betts wrote:
> >On Thu, Mar 01, 2007 at 03:29:26PM +0000, richard wrote:
> >>* common/utils.c,common/utils.h: For windows, add an 
> >>om_tostring()function for
> >>  64 bit integers: time() and GetProcessId() return these, and without 
> >>  this,
> >>  backends/quartz/quartz_log.cc reports an error.

If this is only required by the quartz log stuff, I wonder if we should
just drop that code.

It doesn't get used unless you touch "log" in a quartz database by hand,
but that's not documented anywhere so I doubt anybody except you and me
knows to even try it!  We could document it, but I never actually found
it a useful debugging aid, and haven't used it at all in years.  Plus
quartz will be deprecated for new systems as of 1.0 anyway.

But I suspect support for 64 bit integers is also required for the debug
logging code.

Hmm, and I don't understand how this worked for MSVC before this patch
if it gives an error now.  Or why I haven't seen an error building for
mingw.

> >This change generates a new warning in the mingw cross-build:
> >
> >common/utils.cc:82: warning: int format, different type arg (arg 3)
> >
> >Presumably this warning is bogus, since mingw uses the MSVC C runtime
> >DLL?
> 
> It sounds pretty bogus - perhaps the best plan would be to put together 
> a test (presumably in internaltest.cc) which checked that it was working 
> correctly.  I'll look into that shortly.

A testcase is a good idea, but it's going to be tricky for me to
exercise it in a cross-build...

Cheers,
    Olly